yfqh's recent timeline updates
yfqh

yfqh

V2EX member #498693, joined on 2020-07-11 16:17:04 +08:00
C++代码问题咨询
程序员  •  yfqh  •  Nov 24, 2022  •  Lastly replied by yfqh
2
广东电信游戏宽带问题咨询
宽带症候群  •  yfqh  •  Jul 11, 2022  •  Lastly replied by bosonx
2
yfqh's recent replies
Nov 24, 2022
Replied to a topic by yfqh 程序员 C++代码问题咨询
@brucedone 下面是初始的代码段

auto start_type = media::Pipeline::StartType::kNormal;
if ((GetDemuxerType() != media::DemuxerType::kChunkDemuxer) &&
preload_ == media::DataSource::METADATA &&
!client_->CouldPlayIfEnoughData() && !IsStreaming()) {
start_type =
(has_poster_ ||
base::FeatureList::IsEnabled(media::kPreloadMetadataLazyLoad))
? media::Pipeline::StartType::kSuspendAfterMetadata
: media::Pipeline::StartType::kSuspendAfterMetadataForAudioOnly;
attempting_suspended_start_ = true;
}

这是我修改后的

auto start_type = media::Pipeline::StartType::kNormal;
if ((GetDemuxerType() != media::DemuxerType::kChunkDemuxer) &&
preload_ == media::DataSource::METADATA &&
!client_->CouldPlayIfEnoughData() && !IsStreaming()) {
start_type =
(has_poster_
? media::Pipeline::StartType::kSuspendAfterMetadata
: media::Pipeline::StartType::kSuspendAfterMetadataForAudioOnly);
attempting_suspended_start_ = true;
}

我现在要将 base::FeatureList::IsEnabled(media::kPreloadMetadataLazyLoad)删去,但删去后好像发现会存在其他问题,这是 Chromium 工程师给的回复,我暂时还没有其他的修改思路。

The original code was: start_type = (has_poster_ || true) ? kSuspendAfterMetadata : kSuspendAfterMetadataForAudioOnly;

Patchset 9 changed it to: start_type = (has_poster_) ? kSuspendAfterMetadata : kSuspendAfterMetadataForAudioOnly;

Patchset 11 changed it to: start_type = (has_poster_ ? kSuspendAfterMetadata : kSuspendAfterMetadataForAudioOnly);

Shouldn't the code be: start_type = kSuspendAfterMetadata; ?

There may be some additional cleanup of kSuspendAfterMetadataForAudioOnly.
打算开一个车,又想上车的吗,买 4 个出三个
图片看不了啊
About   ·   Help   ·   Advertise   ·   Blog   ·   API   ·   FAQ   ·   Solana   ·   2702 Online   Highest 6679   ·     Select Language
创意工作者们的社区
World is powered by solitude
VERSION: 3.9.8.5 · 15ms · UTC 05:06 · PVG 13:06 · LAX 22:06 · JFK 01:06
♥ Do have faith in what you're doing.